feat: translate UI to Spanish #179
Conversation
|
@fmaclen for now I've added the translations to spanish. I still have to implement the switch between languages. I've used Claude to give me advice on some of them. I still have doubts on a few ones, for example 'Prompt'. What do you think? |
There was a problem hiding this comment.
@GregoMac1 this translations look good, the one for prompt is kinda weird but it's fine for now.
I edited the original issue and added a short list of tasks we should include in this PR:
#151
|
@fmaclen as the settings page is divided into categories, I added a 'Preferences' category to contain the language switch input, but feel free to change/remove it. |
src/routes/+layout.svelte
Outdated
| if (!$settingsStore.userLanguage) | ||
| $settingsStore.userLanguage = detectLocale('en', ['en', 'es']) as Locales; |
There was a problem hiding this comment.
detectLocale accepts a fallback language as first parameter, and a list of available locales as second parameter. Ref
Deploying hollama with
|
| Latest commit: |
3ad39a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://985c2a26.hollama.pages.dev |
| Branch Preview URL: | https://151-translate-to-spanish.hollama.pages.dev |
fmaclen
changed the title
There was a problem hiding this comment.
This is pretty good so far 👍
Left you a couple of minor changes.
Also pushed a few styling fixes because in Spanish strings are often much longer and the UI was wrapping weirdly.
Last but not least, we needs some tests:
- User can set the language preference to
es, and back toen. - If the user's browser is in
esmake sure that's loaded by default, I think you can achieve this by emulating the test options, thought instead of defining a config we shouldtest.use() - Update the snapshots
npx playwright test --update-snapshots
src/routes/settings/Language.svelte
Outdated
| <FieldSelect | ||
| name="language" | ||
| label={$LL.language()} | ||
| bind:value | ||
| options={[ | ||
| { value: 'en', option: 'English' }, | ||
| { value: 'es', option: 'Español' } | ||
| ]} | ||
| /> | ||
| </Fieldset> |
There was a problem hiding this comment.
This looks good, the only thing we are missing here is that we should set the default state for value, right now the field is empty when the page loads.
<FieldSelect> has this issue where we are hard-coding an empty <option></option> which doesn't make sense for this field, but I'm currently doing a big refactor of <FieldSelect> in #181 so don't worry about fixing that. I'll fill you in on the thought process behind that next time we talk.
There was a problem hiding this comment.
@GregoMac1 we still need to do the first part of this comment which is setting the default value.
And it'd probably be good to add assertions for the default values in both of the tests.
There was a problem hiding this comment.
I now realize that my comment was a bit ambiguous, I meant not to worry about fixing the hardcoded empty value, but we still need a default value 😅
|
@fmaclen I've added the tests you mentioned. Could you please try updating the snapshots? I've already done so but the test is still failing. Thanks! |
Done! |
|
@fmaclen I've updated the test, so I think this would be ready to be merged. However, the snapshots test is still failing. I updated the snapshots and the test passes on my computer, but the GH Action fails. I don't really know how to debug this further. |
@GregoMac1 I think the issue with the snapshots is still indeed the antialias and how sensitive the config is: I increased it to 900 pixels, hopefully this is strikes a good balance for catching actual UI changes and not false positive. |
|
Awesome! Thanks! |
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.