Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bus overrun error #9

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Fix/bus overrun error #9

merged 3 commits into from
Jan 29, 2021

Conversation

flynneva
Copy link
Owner

@flynneva flynneva commented Jan 29, 2021

closes #5

@flynneva flynneva requested a review from whatis777 January 29, 2021 00:14
Copy link
Collaborator

@whatis777 whatis777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea with the separate exception!
Just some findings regarding comments & inheritance

bno055/error_handling/exceptions.py Outdated Show resolved Hide resolved
bno055/bno055.py Outdated Show resolved Hide resolved
bno055/connectors/Connector.py Show resolved Hide resolved
@flynneva flynneva requested a review from whatis777 January 29, 2021 16:30
@flynneva
Copy link
Owner Author

flynneva commented Jan 29, 2021

@whatis777 i removed the extra lint action step since the final step is still performing the linting checks

i think im going to make another PR to update the CI and add some release actions

@flynneva flynneva merged commit c682f18 into develop Jan 29, 2021
@flynneva flynneva deleted the fix/bus_overrun_error branch February 4, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BNO055 somtimes sends BUS_OVER_RUN_ERROR (0x07) over UART
2 participants