file: fix tmpfiles-clean config

FC-40636 IOReadIOPSMax/IOWriteIOPSMax are part of the `[Service]` section.
flyingcircusio · Sep 5, 2024 · d92f27b · d92f27b
1 parent f09e356
commit d92f27b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGES.d/20240905_115653_mb_FC_40636_systemd_settings.md b/CHANGES.d/20240905_115653_mb_FC_40636_systemd_settings.md
@@ -0,0 +1,6 @@
+* The `SymlinkAndCleanup` internally uses the `DeploymentTrash` component internally which
+  deletes old code using `systemd-tmpfiles` and throttles the operation with `IOReadIOPSMax`
+  and `IOWriteIOPSMax`.
+
+  This didn't have any effect before because these settings were wrongly placed in `[Unit]`
+  instead of `[Service]`.
diff --git a/src/batou_ext/file.py b/src/batou_ext/file.py
@@ -178,7 +178,7 @@ def configure(self):
                 "d {{component.trashdir}} 0755 - - 1h -"
               ];
 
-              systemd.services."systemd-tmpfiles-clean".unitConfig = {
+              systemd.services."systemd-tmpfiles-clean".serviceConfig = {
                 IOReadIOPSMax="{{component.trashdir}} {{component.read_iops_limit}}";
                 IOWriteIOPSMax="{{component.trashdir}} {{component.write_iops_limit}}";
               };