Fix flux ListImagesWithOptions v10 #1146

aaron7 · 2018-06-15T14:02:56Z

Use an interface for dispatching ListImages and ListServices to the rpc clients
Add RegisterDaemonV10 constant

squaremo

LGTM, coffee time!

remote/rpc/clientV6.go

+	return listImagesWithOptions(ctx, p, opts)
+}
+
+type listImagesWithOptionsClient interface {


remote/rpc/clientV6.go

+// listImagesWithOptions is called by ListImagesWithOptions so we can use an
+// interface to dispatch .ListImages() and .ListServices() to the correct
+// API version.
+func listImagesWithOptions(ctx context.Context, client listImagesWithOptionsClient, opts v10.ListImagesOptions) ([]v6.ImageStatus, error) {


aaron7 added 2 commits June 15, 2018 14:52

Use interface for ListImagesWithOptions in rpc clients

22de95c

Add RegisterDaemonV10 constant

d865c11

aaron7 requested a review from squaremo June 15, 2018 14:02

Create RegisterDaemonV10 route

8f87f63

squaremo approved these changes Jun 15, 2018

View reviewed changes

remote/rpc/clientV6.go

return listImagesWithOptions(ctx, p, opts)

}

type listImagesWithOptionsClient interface {

This comment was marked as abuse.

Sign in to view

Add comment about listImagesWithOptions rpc method

b14b53c

aaron7 merged commit b7b1a51 into master Jun 15, 2018

aaron7 deleted the flux-fix-list-images-v10 branch June 15, 2018 14:18

aaron7 mentioned this pull request Jun 15, 2018

Update flux and create registerV10 endpoint weaveworks/service#2108

Merged

squaremo reviewed Jun 15, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix flux ListImagesWithOptions v10 #1146

Fix flux ListImagesWithOptions v10 #1146

aaron7 commented Jun 15, 2018

squaremo left a comment

This comment was marked as abuse.

This comment was marked as abuse.

Fix flux ListImagesWithOptions v10 #1146

Fix flux ListImagesWithOptions v10 #1146

Conversation

aaron7 commented Jun 15, 2018

squaremo left a comment

Choose a reason for hiding this comment

This comment was marked as abuse.

This comment was marked as abuse.