Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalizer: refactoring #531

Merged
merged 1 commit into from
Mar 29, 2020
Merged

finalizer: refactoring #531

merged 1 commit into from
Mar 29, 2020

Conversation

mathetake
Copy link
Collaborator

refactored #495

@mathetake mathetake force-pushed the refactor-finalizer branch from f5ad107 to ef8b6fe Compare March 29, 2020 08:07
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #531 into master will increase coverage by 0.18%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   50.50%   50.69%   +0.18%     
==========================================
  Files          63       63              
  Lines        4940     4902      -38     
==========================================
- Hits         2495     2485      -10     
+ Misses       2035     2005      -30     
- Partials      410      412       +2     
Impacted Files Coverage Δ
pkg/canary/daemonset_controller.go 59.64% <0.00%> (ø)
pkg/canary/service_controller.go 0.00% <0.00%> (ø)
pkg/canary/status.go 47.85% <0.00%> (ø)
pkg/controller/controller.go 1.33% <0.00%> (ø)
pkg/router/appmesh.go 85.14% <0.00%> (ø)
pkg/router/contour.go 88.19% <0.00%> (ø)
pkg/router/gloo.go 70.00% <0.00%> (ø)
pkg/router/ingress.go 53.54% <0.00%> (ø)
pkg/router/kubernetes_noop.go 0.00% <0.00%> (ø)
pkg/router/nop.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7676918...ef8b6fe. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mathetake

@mathetake mathetake merged commit 388ad04 into master Mar 29, 2020
@mathetake mathetake deleted the refactor-finalizer branch March 29, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants