feat: remove locale (#8)

flozero · Jun 20, 2023 · 96956a3 · 96956a3
1 parent ba858e7
commit 96956a3
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -93,7 +93,6 @@ export default defineNuxtConfig({
   stripe: { 
     publishableKey: 'pk_test_123', // required
     apiKey: 'sk_test_123' // required,
-    locale: string,
     apiVersion: string, // default 2022-11-15
   }
 })

diff --git a/src/module.ts b/src/module.ts
@@ -1,5 +1,5 @@
 import { defineNuxtModule, addPlugin, createResolver, addTemplate, resolveModule } from '@nuxt/kit'
-import defu from "defu"
+import defu from 'defu'
 import { fileURLToPath } from 'url'
 
 export interface ModuleOptions {
@@ -15,15 +15,17 @@ export interface ModuleOptions {
    * Stripe private key for server side only
    * @example 'pk_test_yOipfsEBmvrjWhSJFMCMX0yf'
    * @type string | null
-   * @docs https://...
+   * @docs https://stripe.com/docs/api/authentication
    */
   apiKey: string | null,
 
-  // TODO: add more options
-  locale: string,
-
-  // TODO: add more options
-  apiVersion: string | "2022-11-15"
+  /**
+   * Stripe api version for server side only
+   * @example '2022-11-15'
+   * @type string | '2022-11-15'
+   * @docs https://stripe.com/docs/api/versioning
+   */
+  apiVersion: string | '2022-11-15'
 }
 
 export default defineNuxtModule<ModuleOptions>({
@@ -37,8 +39,7 @@ export default defineNuxtModule<ModuleOptions>({
   defaults: {
       publishableKey: null,
       apiKey: null,
-      locale: 'en',
-      apiVersion: "2022-11-15"
+      apiVersion: '2022-11-15'
   },
   setup (options, nuxt) {
     const { resolve } = createResolver(import.meta.url)
@@ -57,7 +58,6 @@ export default defineNuxtModule<ModuleOptions>({
     // Public runtimeConfig
     nuxt.options.runtimeConfig.public.stripe = defu(nuxt.options.runtimeConfig.public.stripe, {
       publishableKey: options.publishableKey,
-      locale: options.locale,
       apiVersion: options.apiVersion
     })
 

diff --git a/test/basic.test.ts b/test/basic.test.ts
@@ -18,7 +18,6 @@ describe('ssr', async () => {
     const html = await $fetch('/')
     expect(html).toContain('publishableKey:"pk_test_123"')
     expect(html).toContain('apiVersion:"2021-01-01"')
-    expect(html).toContain('locale:"fr"')
   })
 
   it.todo("validate ssr config")

diff --git a/test/fixtures/basic/nuxt.config.ts b/test/fixtures/basic/nuxt.config.ts
@@ -6,6 +6,5 @@ export default defineNuxtConfig({
     publishableKey: "pk_test_123",
     apiKey: "sk_test_123",
     apiVersion: "2021-01-01",
-    locale: "fr"
   }
 })