Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): added error strategy option #743

Merged
merged 1 commit into from
Feb 21, 2025
Merged

feat(android): added error strategy option #743

merged 1 commit into from
Feb 21, 2025

Conversation

erka
Copy link
Collaborator

@erka erka commented Feb 21, 2025 •
edited
Loading

related #737

@erka erka force-pushed the rd/android-error-strategy branch from 1e3bbcc to dc52269 Compare February 21, 2025 11:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (4a1943b) to head (8ec1a96).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files           7        7           
  Lines        3927     3927           
=======================================
  Hits         3352     3352           
  Misses        575      575

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka force-pushed the rd/android-error-strategy branch 2 times, most recently from 42b6e72 to c1c0ebc Compare February 21, 2025 12:05
@erka erka marked this pull request as ready for review February 21, 2025 12:35
@erka erka requested a review from a team as a code owner February 21, 2025 12:35
@erka erka force-pushed the rd/android-error-strategy branch from c1c0ebc to 8ec1a96 Compare February 21, 2025 12:38
@erka erka mentioned this pull request Feb 21, 2025
Closed
markphelps
markphelps approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you @erka !!

@erka erka merged commit d779e19 into main Feb 21, 2025
25 checks passed
@erka erka deleted the rd/android-error-strategy branch February 21, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erka @codecov-commenter @markphelps