WIP: fix calling conventions #1464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pursuit of #1462, this series of diffs will reform the calling conventions in Caiman to not have methods return self, and to have calling/sample code in our codebase not rely on that.
This will hopefully make it more clear that when a method returns an object, it's a distinct object, and make our code more conventional. There's a lot of code to change; I don't know if I'll get everything in a single PR.
This will be a breaking change. There's also a chance that this may be a bad idea and we'll back off on this change, either just for now or permanently.
(this PR will change its title before it will be ready to merge)