platform/machine/packet: use API to delete device

since the mach.Destroy only adds devices to the pool, we don't need to
rely on it to actually remove a device.

Signed-off-by: Mathieu Tortuyaux <[email protected]>

platform/machine/packet/cluster.go

@@ -98,37 +98,37 @@ func (pc *cluster) NewMachine(userdata *conf.UserData) (platform.Machine, error)
 		mach.publicIP = pc.flight.api.GetDeviceAddress(device, 4, true)
 		mach.privateIP = pc.flight.api.GetDeviceAddress(device, 4, false)
 		if mach.publicIP == "" || mach.privateIP == "" {
-			mach.Destroy()
+			pc.flight.api.DeleteDevice(mach.ID())
 			err = fmt.Errorf("couldn't find IP addresses for device")
 			continue // provisioning error
 		}
 
 		dir := filepath.Join(pc.RuntimeConf().OutputDir, mach.ID())
 		if err = os.Mkdir(dir, 0777); err != nil {
-			mach.Destroy()
+			pc.flight.api.DeleteDevice(mach.ID())
 			return nil, err
 		}
 
 		if cons != nil {
 			if err = os.Rename(consolePath, filepath.Join(dir, "console.txt")); err != nil {
-				mach.Destroy()
+				pc.flight.api.DeleteDevice(mach.ID())
 				return nil, err
 			}
 		}
 
 		confPath := filepath.Join(dir, "user-data")
 		if err = conf.WriteFile(confPath); err != nil {
-			mach.Destroy()
+			pc.flight.api.DeleteDevice(mach.ID())
 			return nil, err
 		}
 
 		if mach.journal, err = platform.NewJournal(dir); err != nil {
-			mach.Destroy()
+			pc.flight.api.DeleteDevice(mach.ID())
 			return nil, err
 		}
 
 		if err = platform.StartMachine(mach, mach.journal); err != nil {
-			mach.Destroy()
+			pc.flight.api.DeleteDevice(mach.ID())
 			continue // provisioning error
 		}