feat: preference #2458
Merged
feat: preference #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* use jotai for topology card size
adityathebe
force-pushed
the
feat/preference
branch
from
3031d66 to
2cb23e3
Compare
moshloop
reviewed
Feb 17, 2025
moshloop
reviewed
Feb 18, 2025
moshloop
reviewed
Feb 18, 2025
moshloop
reviewed
Feb 18, 2025
moshloop
reviewed
Feb 18, 2025
moshloop
reviewed
Feb 18, 2025
moshloop
reviewed
Feb 18, 2025
moshloop
reviewed
Feb 18, 2025
|
On first loading the popover it only shows the value and nothing in the dropdown - I think switch to ReactSelectDropdown - and if preferences needs to be a modal thats also ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #2454