Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex AI] Make Constants file internal and fix typos #12916

Merged
merged 1 commit into from
May 8, 2024
Merged

[Vertex AI] Make Constants file internal and fix typos #12916

merged 1 commit into from
May 8, 2024

Conversation

andrewheard
Copy link
Contributor

  • Renamed GenerativeAISwift to Constants and made it internal instead of public.
    • Not needed for external use.
  • Fixed intepretable and indiciate typos.
  • Expanded on VertexAI class docs.

#no-changelog

@andrewheard andrewheard merged commit 3b2869c into release-10.26 May 8, 2024
42 checks passed
@andrewheard andrewheard deleted the ah/vertex-ai-constants branch May 8, 2024 15:50
andrewheard added a commit that referenced this pull request May 13, 2024
@andrewheard
[Vertex AI] Make Constants file internal and fix typos (#12916)
a2292e4
andrewheard added a commit that referenced this pull request May 13, 2024
@andrewheard
[Vertex AI] Make Constants file internal and fix typos (#12916)
f7488f4
@firebase firebase locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777