Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reword parameter name #12502

Merged
merged 1 commit into from
Mar 9, 2024
Merged

reword parameter name #12502

merged 1 commit into from
Mar 9, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Mar 8, 2024 •
edited
Loading

reword param name

#no-changelog

@themiswang themiswang requested review from danasilver and ddnan March 8, 2024 21:47
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@themiswang themiswang mentioned this pull request Mar 8, 2024
Merged
@themiswang themiswang marked this pull request as ready for review March 8, 2024 21:53
ddnan
ddnan approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@ddnan ddnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rewording.

@themiswang themiswang merged commit 2b569c5 into featureRollouts Mar 9, 2024
68 checks passed
@themiswang themiswang deleted the fixRolloutsTests branch March 9, 2024 00:32
themiswang added a commit that referenced this pull request Mar 11, 2024
@themiswang
reword parameter name (#12502)
37fce03
@firebase firebase locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danasilver danasilver danasilver approved these changes

@ddnan ddnan ddnan approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @google-oss-bot @danasilver @ddnan