Skip to content

Commit

Permalink
[auth-swift] Fix two flow porting errors in AuthURLPresenter.swift (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
paulb777 authored May 20, 2024
1 parent 4a0f631 commit a5af29d
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions FirebaseAuth/Sources/Swift/Utilities/AuthURLPresenter.swift
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,19 @@
return false
}

// MARK: SFSafariViewControllerDelegate

func safariViewControllerDidFinish(_ controller: SFSafariViewController) {
kAuthGlobalWorkQueue.async {
if controller == self.safariViewController {
// TODO: Ensure that the SFSafariViewController is actually removed from the screen
// before invoking finishPresentation
self.finishPresentation(withURL: nil,
error: AuthErrorUtils.webContextCancelledError(message: nil))
}
}
}

// MARK: AuthWebViewControllerDelegate

func webViewControllerDidCancel(_ controller: AuthWebViewController) {
Expand Down Expand Up @@ -156,8 +169,8 @@
let webViewController = self.webViewController
self.webViewController = nil
if safariViewController != nil || webViewController != nil {
uiDelegate?.dismiss(animated: true) {
kAuthGlobalWorkQueue.async {
DispatchQueue.main.async {
uiDelegate?.dismiss(animated: true) {
self.isPresenting = false
if let completion {
completion(url, error)
Expand Down

0 comments on commit a5af29d

Please sign in to comment.