Add todo

firebase · Feb 26, 2025 · 7aa43d5 · 7aa43d5
1 parent 07b05a8
commit 7aa43d5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/FirebaseVertexAI/Sources/Chat.swift b/FirebaseVertexAI/Sources/Chat.swift
@@ -44,9 +44,9 @@ public final class Chat: Sendable {
   }
 
   private func appendHistory(contentsOf: [ModelContent]) {
-    historyLock.lock()
-    _history.append(contentsOf: contentsOf)
-    historyLock.unlock()
+    historyLock.withLock {
+      _history.append(contentsOf: contentsOf)
+    }
   }
 
   /// Sends a message using the existing history of this chat as context. If successful, the message

diff --git a/FirebaseVertexAI/Sources/FirebaseInfo.swift b/FirebaseVertexAI/Sources/FirebaseInfo.swift
@@ -14,6 +14,7 @@
 
 import Foundation
 
+// TODO: Remove `@preconcurrency` when possible.
 @preconcurrency import FirebaseAppCheckInterop
 @preconcurrency import FirebaseAuthInterop
 @preconcurrency import FirebaseCore