perf(query) Remove unnecessary serialization if the execution is local #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivik
reviewed
Mar 13, 2025
alextheimer
reviewed
Mar 27, 2025
alextheimer
reviewed
Mar 27, 2025
alextheimer
approved these changes
Mar 27, 2025
amolnayak311
added a commit
to amolnayak311/FiloDB
that referenced
this pull request
Mar 27, 2025
amolnayak311
added a commit
to amolnayak311/FiloDB
that referenced
this pull request
Mar 27, 2025
amolnayak311
added a commit
that referenced
this pull request
Mar 27, 2025
amolnayak311
added a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior :
The makeResult converts the
RangeVectorto aSerializableRangeVectorif it's not one. This prevents us from benefiting from target schema optimization where both LHS and RHS are on the same shard. We end up serializing the range vector even if we don't have toNew behavior :
We check the
dispatcherin theExecPlanand if it is a local, we don't convert theRangeVectortoSerializedRangeVector