Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency lint-staged to v15.5.0 #968

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 12, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
lint-staged 15.4.3 -> 15.5.0 age adoption passing confidence

Release Notes

lint-staged/lint-staged (lint-staged)

v15.5.0

Compare Source

Minor Changes
  • #​1526 630af5f Thanks @​iiroj! - Lint-staged no longer resets to the original state when preventing an empty git commit. This happens when your configured tasks reset all the staged changes, typically when trying to commit formatting changes which conflict with your linter setup like ESLint or Prettier.
Example with Prettier

By default Prettier prefers double quotes.

Previously
  1. Stage file.js with only double quotes " changed to '
  2. Run git commit -am "I don't like double quotes"
  3. Lint-staged runs prettier --write file.js, converting all the ' back to "
  4. Because there are now no changes, lint-staged fails, cancels the commit, and resets back to the original state
  5. Commit was not done, original state is restored and single quotes ' are staged
Now
  1. Stage file.js with only double-quotes " changed to '
  2. Run git commit -am "I don't like double quotes"
  3. Lint-staged runs prettier --write file.js, converting all the ' back to "
  4. Because there are now no changes, lint-staged fails and cancels the commit
  5. Commit was not done, and there are no staged changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor

Review

The changes in this PR update the lint-staged dependency from version 15.4.3 to 15.5.0. The update includes a minor change that prevents lint-staged from resetting to the original state when there are no changes after running configured tasks, which can happen when formatting changes conflict with linter setups.

Review:

No issues found that could cause bugs, security issues, significant performance impacts, or make the code harder to maintain.

The update appears to be a minor enhancement that improves the behavior of lint-staged in specific scenarios, which should not introduce any regressions or issues.

Conclusion:

The PR can be merged. The update is safe and beneficial for the project.

Good job on keeping dependencies up to date!

@felladrin felladrin merged commit 916cfe4 into main Mar 12, 2025
3 checks passed
@felladrin felladrin deleted the renovate/lint-staged-15.x-lockfile branch March 12, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant