🐛 Fix Bash completion setup to .bashrc

fastapi · Mar 28, 2020 · 2eb158d · 2eb158d · github-actions · Mar 28, 2020
1 parent b28f920
commit 2eb158d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/tests/test_completion/test_completion.py b/tests/test_completion/test_completion.py
@@ -22,7 +22,7 @@ def test_show_completion():
 
 
 def test_install_completion():
-    bash_completion_path: Path = Path.home() / ".bash_completion"
+    bash_completion_path: Path = Path.home() / ".bashrc"
     text = ""
     if bash_completion_path.is_file():  # pragma: nocover
         text = bash_completion_path.read_text()

diff --git a/tests/test_completion/test_completion_install.py b/tests/test_completion/test_completion_install.py
@@ -30,7 +30,7 @@ def test_completion_install_no_shell():
 
 
 def test_completion_install_bash():
-    bash_completion_path: Path = Path.home() / ".bash_completion"
+    bash_completion_path: Path = Path.home() / ".bashrc"
     text = ""
     if bash_completion_path.is_file():
         text = bash_completion_path.read_text()

diff --git a/typer/completion.py b/typer/completion.py
@@ -166,7 +166,7 @@ def install(
         shell, _ = shellingham.detect_shell()
     mode = None
     if shell == "bash":
-        path_obj = Path.home() / ".bash_completion"
+        path_obj = Path.home() / ".bashrc"
         mode = mode or "a"
     elif shell == "zsh":
         path_obj = Path.home() / ".zshrc"