-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: Add k8saudit-ovh plugin #554
Conversation
Welcome @scraly! It looks like this is your first PR to falcosecurity/plugins 🎉 |
Rules files suggestionsrulesComparing Patch changes:
|
I changed the Plugin ID 21 to 22 in |
/assign |
Hey @scraly Thank you so much for this PR and contribution. I'm thrilled you wanted to donate this and propose to yourself (within tin @Issif) as a maintainer 🙏 Since this is a maintainer addition, as per our governance, we will go with a quick majority vote among @falcosecurity/plugins-maintainers. This process will take no more than one week. Meanwhile, we will start reviewing the code. You may expect some delay, considering the upcoming holidays, but I want to let you know that we are on it :) Thanks |
Hi and happy new year :) Thanks |
Hey! Happy New Year :) We are just waiting for some other maintainer to vote/review. And, even though I haven't reviewed the PR in detail, I can already give my +1 for adding this plugin :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+1 for me as well! |
Hey @scraly The vote is concluded with more votes in favor than against, so we can proceed 🥳 Next steps:
Once both steps are complete, we can finally merge this PR 😺 |
Signed-off-by: Aurelie Vache <[email protected]>
Signed-off-by: scraly <[email protected]>
Signed-off-by: scraly <[email protected]>
/verify-owners |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, scraly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 58e0405a7a408208b5b0cb4122d2c6782fba666e
|
Rules files suggestions |
Thanks 🥰 |
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
Add "k8saudit-ovh" plugin as an alternative to "k8saudit".
URL of the plugin: https://github.com/scraly/k8saudit-ovh/