Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: Add k8saudit-ovh plugin #554

Merged
merged 3 commits into from
Jan 16, 2025
Merged

vote: Add k8saudit-ovh plugin #554

merged 3 commits into from
Jan 16, 2025

Conversation

scraly
Copy link
Contributor

@scraly scraly commented Dec 19, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

Add "k8saudit-ovh" plugin as an alternative to "k8saudit".

URL of the plugin: https://github.com/scraly/k8saudit-ovh/

@poiana
Copy link
Contributor

poiana commented Dec 19, 2024

Welcome @scraly! It looks like this is your first PR to falcosecurity/plugins 🎉

Copy link

Rules files suggestions

rules

Comparing 174b5fb03a5bee0ce672641a3393c63be5fe3056 with latest tag plugins/k8saudit/v0.11.0

Patch changes:

  • Version dependency alternative to plugin k8saudit-ovh has added
  • Version dependency alternative to plugin k8saudit-ovh has added
  • Version dependency alternative to plugin k8saudit-ovh has added

@scraly
Copy link
Contributor Author

scraly commented Dec 19, 2024

I changed the Plugin ID 21 to 22 in registry.yaml file because it seems that in another PR the AKS Audit Log plugin will be the 21 ;)

@leogr
Copy link
Member

leogr commented Dec 19, 2024

/assign

@leogr
Copy link
Member

leogr commented Dec 19, 2024

Hey @scraly

Thank you so much for this PR and contribution. I'm thrilled you wanted to donate this and propose to yourself (within tin @Issif) as a maintainer 🙏

Since this is a maintainer addition, as per our governance, we will go with a quick majority vote among @falcosecurity/plugins-maintainers. This process will take no more than one week.

Meanwhile, we will start reviewing the code. You may expect some delay, considering the upcoming holidays, but I want to let you know that we are on it :)

Thanks

@leogr leogr changed the title Add k8saudit-ovh plugin vote: Add k8saudit-ovh plugin Dec 19, 2024
@scraly
Copy link
Contributor Author

scraly commented Jan 7, 2025

Hi and happy new year :)
Have you got some news about this PR? :)

Thanks

@leogr
Copy link
Member

leogr commented Jan 7, 2025

Hi and happy new year :) Have you got some news about this PR? :)

Thanks

Hey! Happy New Year :)

We are just waiting for some other maintainer to vote/review.

And, even though I haven't reviewed the PR in detail, I can already give my +1 for adding this plugin :)

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@LucaGuerra
Copy link
Contributor

+1 for me as well!

@leogr
Copy link
Member

leogr commented Jan 16, 2025

Hey @scraly

The vote is concluded with more votes in favor than against, so we can proceed 🥳

Next steps:

  • you will receive a GitHub invitation to join the falcosecurity GitHub invitation shortly. Accept it pls, then let me know
  • we (@LucaGuerra and I) will rebase this PR for the registry file and upgrade golang (we will take care of everything, no action items for you)

Once both steps are complete, we can finally merge this PR 😺

@leogr
Copy link
Member

leogr commented Jan 16, 2025

/verify-owners

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@poiana poiana added the lgtm label Jan 16, 2025
@poiana
Copy link
Contributor

poiana commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, scraly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 16, 2025

LGTM label has been added.

Git tree hash: 58e0405a7a408208b5b0cb4122d2c6782fba666e

@poiana poiana merged commit e7e5531 into falcosecurity:main Jan 16, 2025
8 of 9 checks passed
Copy link

Rules files suggestions

@scraly
Copy link
Contributor Author

scraly commented Jan 17, 2025

Thanks 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants