Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github plugin] split the field github.repo #530

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[github plugin] split the field github.repo #530

merged 2 commits into from
Oct 2, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Sep 17, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Split the field github.repo into github.repo.name and github.repo.url

Which issue(s) this PR fixes:

#300

Fixes #

Special notes for your reviewer:

I didn't updated the changelog, when i use the function in the makefile, it breaks the file, what's the good way to process?

@poiana poiana requested review from leogr and mstemm September 17, 2024 15:41
@poiana poiana added the size/L label Sep 17, 2024
@github-actions GitHub Actions
Copy link

Rules files suggestions

rules

Comparing 90955af7e5a4141f8c8f2b882449ec7cb5f7a8d9 with latest tag plugins/github/v0.7.5

Minor changes:

  • Version dependency to plugin github has been incremented

Patch changes:

  • Rule Private Repository Becoming Public changed its output fields
  • Rule Public Repository Becoming Private changed its output fields
  • Rule Create Public Repository changed its output fields
  • Rule Delete Public Repository changed its output fields
  • Rule Create Repository changed its output fields
  • Rule Delete Repository changed its output fields
  • Rule Create Deploy Key changed its output fields
  • Rule Delete Deploy Key changed its output fields
  • Rule Add Collaborator to Repository changed its output fields
  • Rule Remove Collaborator from Repository changed its output fields
  • Rule Secret pushed into a public repository changed its output fields
  • Rule Secret pushed into a private repository changed its output fields
  • Rule Github action with miners changed its output fields

@Issif Issif force-pushed the feature-request/github-repo-name branch from 90955af to 546482a Compare September 18, 2024 12:41
@github-actions GitHub Actions
Copy link

Rules files suggestions

rules

Comparing 546482a8b376519d63a9fa8b0eaf10a67315c35d with latest tag plugins/github/v0.7.5

Minor changes:

  • Version dependency to plugin github has been incremented

Patch changes:

  • Rule Private Repository Becoming Public changed its output fields
  • Rule Public Repository Becoming Private changed its output fields
  • Rule Create Public Repository changed its output fields
  • Rule Delete Public Repository changed its output fields
  • Rule Create Repository changed its output fields
  • Rule Delete Repository changed its output fields
  • Rule Create Deploy Key changed its output fields
  • Rule Delete Deploy Key changed its output fields
  • Rule Add Collaborator to Repository changed its output fields
  • Rule Remove Collaborator from Repository changed its output fields
  • Rule Secret pushed into a public repository changed its output fields
  • Rule Secret pushed into a private repository changed its output fields
  • Rule Github action with miners changed its output fields

@Issif
[github plugin] split the field github.repo into github.repo.name and…
39a0bc7 
… github.repo.url for easier to write rules + fix bad indentation in the registry table

Signed-off-by: Thomas Labarussias <[email protected]>

update the upload-artifact action version

Signed-off-by: Thomas Labarussias <[email protected]>
@Issif Issif force-pushed the feature-request/github-repo-name branch from 546482a to 7739d0c Compare September 18, 2024 15:10
@Issif Issif force-pushed the feature-request/github-repo-name branch from 7739d0c to 2291564 Compare September 18, 2024 15:12
@github-actions GitHub Actions
Copy link

Rules files suggestions

rules

Comparing 2291564d8b0ddf27ffb57cf1ed323d02eabd73bd with latest tag plugins/github/v0.7.5

Minor changes:

  • Version dependency to plugin github has been incremented

Patch changes:

  • Rule Private Repository Becoming Public changed its output fields
  • Rule Public Repository Becoming Private changed its output fields
  • Rule Create Public Repository changed its output fields
  • Rule Delete Public Repository changed its output fields
  • Rule Create Repository changed its output fields
  • Rule Delete Repository changed its output fields
  • Rule Create Deploy Key changed its output fields
  • Rule Delete Deploy Key changed its output fields
  • Rule Add Collaborator to Repository changed its output fields
  • Rule Remove Collaborator from Repository changed its output fields
  • Rule Secret pushed into a public repository changed its output fields
  • Rule Secret pushed into a private repository changed its output fields
  • Rule Github action with miners changed its output fields

@poiana
Copy link
Contributor

poiana commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Oct 2, 2024

LGTM label has been added.

Git tree hash: 6077cf4478fab5e41cbb6f4608d5b9c7b37a03a4

@poiana poiana merged commit e94e21f into falcosecurity:main Oct 2, 2024
13 checks passed
@leogr leogr mentioned this pull request Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

Labels
approved area/plugins dco-signoff: yes kind/feature New feature or request lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Issif @poiana @leogr