Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::House #1476

Merged
merged 4 commits into from
Nov 16, 2018
Merged

Add Faker::House #1476

merged 4 commits into from
Nov 16, 2018

Conversation

jguthrie100
Copy link
Contributor

Continues on from the accidentally closed (due to deleted branch) #1375 .

Moved files into respective /unreleased/ dirs.

@jguthrie100 jguthrie100 mentioned this pull request Nov 16, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@vbrazo vbrazo merged commit f17f642 into faker-ruby:master Nov 16, 2018
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Added House::furniture, House::appliance and House::room

* Add new line to pass rubucop

* Move files into respective unreleased dirs

* Remove appliances from locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants