Faker::Movies::GratefulDead => Faker::Music::GratefulDead (#1549)

faker-ruby · Feb 23, 2019 · 7431995 · 7431995
1 parent a9a3feb
commit 7431995
Show file tree

Hide file tree

Showing 7 changed files with 54 additions and 4 deletions.
diff --git a/doc/unreleased/music/grateful_dead.md b/doc/unreleased/music/grateful_dead.md
@@ -0,0 +1,8 @@
+# Faker::Music::GratefulDead
+
+
+```ruby
+  Faker::Music::GratefulDead.player #=> "Jerry Garcia"
+
+  Faker::Music::GratefulDead.song #=> "Cassidy"
+```
diff --git a/lib/faker/deprecate/unreleased/movies/grateful_dead.rb b/lib/faker/deprecate/unreleased/movies/grateful_dead.rb
@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Faker
+  module Movies
+    class GratefulDead < Base
+      class << self
+        extend Gem::Deprecate
+
+        def player
+          Faker::Music::GratefulDead.player
+        end
+
+        def song
+          Faker::Music::GratefulDead.song
+        end
+
+        deprecate :player, 'Faker::Music::GratefulDead.player', 2019, 04
+        deprecate :song, 'Faker::Music::GratefulDead.song', 2019, 04
+      end
+    end
+  end
+end
diff --git a/lib/faker/movies/grateful_dead.rb → lib/faker/music/grateful_dead.rb b/lib/faker/movies/grateful_dead.rb → lib/faker/music/grateful_dead.rb
@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
+require_relative 'music'
+
 module Faker
-  module Movies
+  class Music
     class GratefulDead < Base
       class << self
         def player

diff --git a/lib/locales/en/grateful_dead.yml b/lib/locales/en/grateful_dead.yml
@@ -44,4 +44,5 @@ en:
               "The Music Never Stopped",
               "Black Muddy River",
               "Looks Like Rain",
-              "Bird Song"]
+              "Bird Song",
+              "Cassidy"]
diff --git a/.../faker/movies/test_faker_grateful_dead.rb → ...sed/test_deprecate_faker_grateful_dead.rb b/.../faker/movies/test_faker_grateful_dead.rb → ...sed/test_deprecate_faker_grateful_dead.rb
@@ -2,7 +2,7 @@
 
 require_relative '../../test_helper'
 
-class TestFakerMoviesGratefulDead < Test::Unit::TestCase
+class TestDeprecateFakerMoviesGratefulDead < Test::Unit::TestCase
   def setup
     @tester = Faker::Movies::GratefulDead
   end

diff --git a/test/faker/music/test_faker_grateful_dead.rb b/test/faker/music/test_faker_grateful_dead.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require_relative '../../test_helper'
+
+class TestFakerGratefulDead < Test::Unit::TestCase
+  def setup
+    @tester = Faker::Music::GratefulDead
+  end
+
+  def test_player
+    assert @tester.player.match(/\w/)
+  end
+
+  def test_song
+    assert @tester.song.match(/\w/)
+  end
+end
diff --git a/unreleased_README.md b/unreleased_README.md
@@ -247,7 +247,6 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master'
   - [Faker::Movie](doc/unreleased/movies/movie.md)
   - [Faker::Movies::BackToTheFuture](doc/unreleased/movies/back_to_the_future.md)
   - [Faker::Movies::Ghostbusters](doc/unreleased/movies/ghostbusters.md)
-  - [Faker::Movies::GratefulDead](doc/unreleased/movies/grateful_dead.md)
   - [Faker::Movies::HarryPotter](doc/unreleased/movies/harry_potter.md)
   - [Faker::Movies::HitchhikersGuideToTheGalaxy](doc/unreleased/movies/hitchhikers_guide_to_the_galaxy.md)
   - [Faker::Movies::Hobbit](doc/unreleased/movies/hobbit.md)
@@ -259,6 +258,7 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master'
 
 ### Music
   - [Faker::Music](doc/unreleased/music/music.md)
+  - [Faker::Music::GratefulDead](doc/music/grateful_dead.md)
   - [Faker::Music::Phish](doc/unreleased/music/phish.md)
   - [Faker::Music::RockBand](doc/unreleased/music/rock_band.md)
   - [Faker::Music::UmphreysMcgee](doc/unreleased/music/umphreys_mcgee.md)