Add keyword argument to Faker::Games::Dota.quote (#1434)

* Add keyword argument to Faker::Games::Dota.quote * Add missing Dota.quote test * Update dota.md
faker-ruby · Oct 23, 2018 · 42a51f9 · 42a51f9
1 parent a66f07a
commit 42a51f9
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/doc/dota.md b/doc/dota.md
@@ -16,6 +16,7 @@ Faker::Games::Dota.team #=> "Evil Geniuses"
 Faker::Games::Dota.player #=> "Dendi"
 
 # Random quote
+# by default if you don't pass the hero parameter, the quote method will set hero as 'abbadon'
 Faker::Games::Dota.quote #=> "Easy now, this stuff is explosive!"
-Faker::Games::Dota.quote(hero = 'alchemist') #=> "Better living through alchemy!"
+Faker::Games::Dota.quote(hero: 'alchemist') #=> "Better living through alchemy!"
 ```
diff --git a/lib/faker/dota.rb b/lib/faker/dota.rb
@@ -22,7 +22,7 @@ def player
       end
 
       def quote(hero = 'abaddon')
-        Faker::Games::Dota.quote(hero)
+        Faker::Games::Dota.quote(hero: hero)
       end
 
       deprecate :hero, 'Faker::Games::Dota.hero', 2018, 10

diff --git a/lib/faker/games/dota.rb b/lib/faker/games/dota.rb
@@ -20,7 +20,7 @@ def player
           fetch('games.dota.player')
         end
 
-        def quote(hero = 'abaddon')
+        def quote(hero: 'abaddon')
           fetch("games.dota.#{hero}.quote")
         end
       end

diff --git a/test/test_deprecate_dota.rb b/test/test_deprecate_dota.rb
@@ -29,6 +29,10 @@ def test_player
     assert @tester.player.match(/\w+/)
   end
 
+  def test_quotes
+    assert @tester.quote.match(/\w+/)
+  end
+
   def test_heroes_quotes
     @heroes.each do |hero|
       assert_match(/\w+/, @tester.quote(hero))

diff --git a/test/test_faker_dota.rb b/test/test_faker_dota.rb
@@ -31,7 +31,7 @@ def test_player
 
   def test_heroes_quotes
     @heroes.each do |hero|
-      assert_match(/\w+/, @tester.quote(hero))
+      assert_match(/\w+/, @tester.quote(hero: hero))
     end
   end
 end