refactor: datatype number

[Shinigami92]

No description provided.

[codecov]

Codecov Report

Merging #798 (1e9d211) into main (0dfe9a3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1e9d211 differs from pull request most recent head 921a451. Consider uploading reports for the commit 921a451 to get more accurate results

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   99.35%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      179086   177121    -1965     
  Branches      909      907       -2     
==========================================
- Hits       177934   175968    -1966     
- Misses       1096     1097       +1     
  Partials       56       56              

Impacted Files	Coverage Δ
src/datatype.ts	100.00% <100.00%> (ø)
src/utils/user-agent.ts	97.84% <0.00%> (-0.27%)	⬇️
src/lorem.ts	100.00% <0.00%> (ø)
src/company.ts	100.00% <0.00%> (ø)
src/internet.ts	100.00% <0.00%> (ø)
src/locales/en/system/mimeTypes.ts	100.00% <0.00%> (ø)
src/system.ts	96.46% <0.00%> (+0.05%)	⬆️

[ST-DDT]

See my comment above.

[ST-DDT]

Not sure if you want to fix this here, but there is a bug in this method for negative numbers.

faker.datatype.number({ min: -5, max: -4 })

never generates -4 due to the if being there (should always apply)

faker/src/datatype.ts

Line 57 in 0b8cac0

if (max >= 0) {

As an alternative you could just remove the if and its body and add +1 to the max side of the mersenne.rand() call. That way max could be a const as well.