Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): add reproducible results page (WIP) #1491

Closed
wants to merge 5 commits into from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 26, 2022

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 26, 2022
@ST-DDT ST-DDT self-assigned this Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #1491 (622eb70) into next (7d587a2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1491      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2356     2356              
  Lines      236565   236565              
  Branches     1198     1191       -7     
==========================================
- Hits       235702   235686      -16     
- Misses        841      857      +16     
  Partials       22       22              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 91.12% <0.00%> (-5.33%) ⬇️
src/modules/location/index.ts 98.92% <0.00%> (+0.21%) ⬆️

@Shinigami92
Copy link
Member

I would like to have somewhere the word deterministic so if you use google search or the search of algolia it leads to this page.


```ts
faker.seed(42);
faker.person.firstName(); // Garnet
faker.seed(42);
faker.person.lastName(); // Hirthe (1)
faker.person.firstName(); // Peyton
```

To counteract this make sure you call the faker methods in the same order.

```ts
faker.seed(42);
faker.person.firstName(); // Garnet
faker.seed(42);
faker.person.firstName(); // Garnet
faker.person.lastName(); // Hirthe (2)
```

I don't fully understand this section, can you make it even more clear?
Why do I get Hirthe even when I call it at second? (1) -> (2)
If this was just luck, can we regenerate the example?

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 26, 2022

If this was just luck, can we regenerate the example?

Copy&Paste Error - Fixed.

Please note this is a very early draft (<50%).
I just pushed it to gather some suggestions like yours early on.

@ST-DDT ST-DDT closed this Apr 2, 2023
@ST-DDT ST-DDT deleted the docs/reproducible branch April 2, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Return values differ between package version
2 participants