Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile devices into autoprefix target. #3123

Closed

Conversation

MitsuhideOhi
Copy link

Problem

I realized autoprefix is not working on iOS 8 Safari from some commit between 0.9.5 and 1.0.10 release.

This is because current target browser setting in webpack configuration in react-scripts is not including mobile devices which still used by amount of users.

./packages/react-scripts/config/webpack.config.dev.js
./packages/react-scripts/config/webpack.config.prod.js

browsers: [
  '>1%',
  'last 4 versions',
  'Firefox ESR',
  'not ie < 9', // React doesn't support IE8 anyway
]

Below explains visual impact from issue.

  • Works autoprefix on react-script 0.9.5.

  • Not works autoprefix on react-script 1.0.10.

Solution

Include iOS and Android setting into the configuration.

'iOS >= 8',
'android >= 4.0'

Support above android 4.0 and iOS 8 is statistically reasonable from my point of view.
Still there is room for discussion about from which version we will support though.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-scripts-dangerous

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 60fe7a5) has been released on npm for testing purposes.

npm i [email protected]
# or
yarn add [email protected]
# or
create-react-app [email protected] folder/

Thanks for your contribution!

@Timer
Copy link
Contributor

Timer commented Sep 29, 2017

Thanks for this PR, but we don't want to target such old browsers which enable older prefixing -- it has other adverse effects.

I'll close this as it'll eventually be covered under #892.

Thanks for your PR!

@Timer Timer closed this Sep 29, 2017
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants