-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] add build-profile flag #2966
Conversation
Size Change: -2.07 kB (0%) Total Size: 53.5 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
==========================================
- Coverage 52.62% 52.61% -0.01%
==========================================
Files 590 590
Lines 23329 23340 +11
Branches 4643 4644 +1
==========================================
+ Hits 12274 12277 +3
- Misses 11021 11029 +8
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
getProjectConfig: getDynamicPrivateProjectConfigAsync, | ||
opts: { env: buildProfile.profile.env }, | ||
}); | ||
env = configResult.env; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've skipped adding EXPO_NO_DOTENV: '1'
in this case to keep it consistent with eas build
. Additional reasoning:
eas.json
may not define server side variables, in which case we'd want to use.env
to get env vars- will leave it to the user to define
EXPO_NO_DOTENV
ineas.json
as it is not clear what type of env var system they are using.
Subscribed to pull request
Generated by CodeMention |
6bac26d
to
e731f1d
Compare
Why
Add
--build-profile
arg toeas fingerprint:generate
, based on the discussion here: https://exponent-internal.slack.com/archives/C06EFBQK3B7/p1742589956539759?thread_ts=1741971771.992309&cid=C06EFBQK3B7How
--build-profile
flag to specify a build profile from eas.json--environment
flag to use environment variables from a specific environmentTest Plan
eas.json
) get passed in.EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:generate --build-profile production
--environment
and--build-profile
are mutually exclusive:EXPO_DEBUG=1 EXPO_STAGING=1 ~/Documents/eas-cli/packages/eas-cli/bin/run fingerprint:generate --build-profile production --environment production