Add share command #2932
Add share command #2932
Conversation
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
|
Size Change: +11.8 kB (+0.02%) Total Size: 53.5 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 52.64% 52.43% -0.20%
==========================================
Files 588 592 +4
Lines 23203 23475 +272
Branches 4860 4678 -182
==========================================
+ Hits 12212 12307 +95
- Misses 10022 11134 +1112
+ Partials 969 34 -935 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention |
| import { createProgressTracker } from '../utils/progress'; | ||
|
|
||
| export default class BuildUpload extends EasCommand { | ||
| static override description = 'upload a local build and generate a sharable link'; |
There was a problem hiding this comment.
| static override description = 'upload a local build and generate a sharable link'; | |
| static override description = 'upload a local build and generate a sharable link'; | |
| static override hidden = true; |
We can mark it as hidden for now so it is not mentioned in help or docs if we want to beta test it first internally before full public release. The command will work; it just won't be mentioned anywhere.
There was a problem hiding this comment.
Should it be eas share or eas build:share? I believe it only works for builds, right? So maybe we should move it from commands/share.ts to commands/build/share.ts?
| { title: buildFingerprintHash, value: buildFingerprintHash }, | ||
| ], | ||
| }); | ||
| fingerprint = String(selectedAnswer.fingerprint); |
| ? 'android/app/build/outputs/**/*.{apk,aab}' | ||
| : 'ios/build/Build/Products/*simulator/*.app'); |
There was a problem hiding this comment.
I'm not sure if these are compatible with the default artifact path of eas build --local. It would create a build and move it to projectDir/somename.extenstion and not projectDir/ios|android/.... Are these paths the result path as of npx expo:run build?
| ): Promise<AppMetadata> { | ||
| let developmentClient = false; | ||
| let fingerprintHash: string | undefined; | ||
| const simulator = platform === Platform.IOS; |
There was a problem hiding this comment.
is it even a valid use case to share .ipa builds? I'm just curious
Related PRs
Why
Closes ENG-15215
How
Introduce
sharecommand allowing users to upload local buildsAdds
node-stream-zipas dependency to allow us to list files inside App files without extracting the whole appTest Plan
Setup
create build your app locally using Xcode or Android Studio
Actions
easd shareTest Reproduction (Screenshots/Videos/Terminal Output)