[ENG-14625][eas-cli] add `eas build:dev` command #2820

szdziedzic · 2025-01-16T00:32:34Z

Why

https://exponent-internal.slack.com/archives/C1QLM27T9/p1734729481930599?thread_ts=1734708689.473259&cid=C1QLM27T9

Add eas dev command that:

calculates fingerprint
checks if we have simulator/emulator dev client builds with such a fingerprint hash on our servers
a. if we do - it downloads and launches them on the emulator/simulator using the same logic we use for eas build:run
b. if not - such a build is created and launched afterward

How

Do exactly what I mentioned above. Use as much code and functions from build logic and eas build:run that already exist to make it easier to maintain.

Test Plan

Test manually

https://exponent-internal.slack.com/archives/C1QLM27T9/p1736987685783579?thread_ts=1734708689.473259&cid=C1QLM27T9

szdziedzic · 2025-01-16T00:32:51Z

[ENG-14625][eas-cli] add eas build:dev command #2820 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-01-16T00:34:53Z

Subscribed to pull request

File Patterns	Mentions
*/	@khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

github-actions · 2025-01-16T00:35:41Z

Size Change: -289 B (0%)

Total Size: 53.4 MB

Filename	Size	Change
`./packages/eas-cli/dist/eas-linux-x64.tar.gz`	53.4 MB	-289 B (0%)

_{compressed-size-action}

brentvatne · 2025-01-16T01:02:13Z

my main concern here is implementing this as a top level command, which feels like something we'd be committing to - and we may want to use the eas dev command for something else, that maybe does more than what we're doing here (perhaps in addition to this functionality). what if this was eas build:run --dev for now? if that was how to access this functionality i'd be good with rolling it out right away

codecov · 2025-01-16T01:06:43Z

Codecov Report

Attention: Patch coverage is 20.58824% with 108 lines in your changes missing coverage. Please review.

Project coverage is 52.54%. Comparing base (3159550) to head (b82e878).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/eas-cli/src/commands/build/dev.ts	25.27%	64 Missing and 7 partials ⚠️
packages/eas-cli/src/build/configure.ts	11.54%	21 Missing and 2 partials ⚠️
packages/eas-cli/src/build/runBuildAndSubmit.ts	9.10%	10 Missing ⚠️
packages/eas-cli/src/commands/build/index.ts	0.00%	1 Missing ⚠️
packages/eas-cli/src/commands/build/inspect.ts	0.00%	1 Missing ⚠️
packages/eas-cli/src/commands/build/internal.ts	0.00%	1 Missing ⚠️
...ackages/eas-cli/src/commands/project/onboarding.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
- Coverage   52.71%   52.54%   -0.16%     
==========================================
  Files         588      589       +1     
  Lines       22912    23036     +124     
  Branches     4782     4814      +32     
==========================================
+ Hits        12076    12103      +27     
- Misses       9882     9970      +88     
- Partials      954      963       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

szdziedzic · 2025-01-16T09:15:51Z

what if this was eas build:run --dev for now? if that was how to access this functionality i'd be good with rolling it out right away

@brentvatne What do you think about eas build:dev?

linear · 2025-01-16T09:38:21Z

ENG-14625 Add `eas run` command

wschurman

Few minor comments and one question about the build profile. Otherwise looks good to me. Will delegate to a reviewer more familiar with builds for approval though.

packages/eas-cli/src/commands/build/dev.ts

wschurman · 2025-01-17T03:03:30Z

packages/eas-cli/src/build/runBuildAndSubmit.ts

-    projectDir,
-  });
+  const buildProfiles =
+    buildProfilesOverride ??


Just curious (I'm not super familiar with build profiles), from a UX perspective should we require them to specify/choose an existing dev-client-enabled profile instead of creating a virtual profile for them? If not, are there any side effects of creating this "virtual" profile for them?

Hmm, I think what you suggest here might be a better option 🤔 The Current implementation should "magically" work well out of the box for users, but I think it limits the customization of things (like selecting the bun version). I believe that using explicit profiles can also have the benefit of people having a good idea about what settings we apply under the hood for these builds 🤔 What do you think?

Definitely a good question for the reviewers on this who are more familiar with build profiles. I unfortunately only have a very surface-level understanding of them. My comment was spurred by the more general idea that having "virutal"/"synthesized" things often does lead to confusion as you mentioned.

packages/eas-cli/src/build/runBuildAndSubmit.ts

wschurman

Will delegate final approval to other reviewers more familiar with build.

wschurman · 2025-01-22T18:10:26Z

packages/eas-cli/src/build/runBuildAndSubmit.ts

-    projectDir,
-  });
+  const buildProfiles =
+    buildProfilesOverride ??


Definitely a good question for the reviewers on this who are more familiar with build profiles. I unfortunately only have a very surface-level understanding of them. My comment was spurred by the more general idea that having "virutal"/"synthesized" things often does lead to confusion as you mentioned.

packages/eas-cli/src/commands/build/dev.ts

github-actions · 2025-01-30T17:10:38Z

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

szdziedzic marked this pull request as ready for review January 16, 2025 00:34

szdziedzic requested review from khamilowicz, quinlanj, radoslawkrzemien, sjchmiela and wschurman January 16, 2025 00:48

szdziedzic changed the title ~~[eas-cli] add eas dev command~~ [eas-cli] add eas build:dev command Jan 16, 2025

szdziedzic changed the title ~~[eas-cli] add eas build:dev command~~ [ENG-14625][eas-cli] add eas build:dev command Jan 16, 2025

szdziedzic requested a review from brentvatne January 16, 2025 11:46

wschurman reviewed Jan 17, 2025

View reviewed changes

wschurman reviewed Jan 22, 2025

View reviewed changes

szdziedzic added 6 commits January 30, 2025 14:26

[eas-cli] add eas dev command

524f462

update logs

ddec732

rename command do build:dev

95b26ea

filter by dev client

93eab5e

apply suggested changes

dd583fd

use real vs virtaul build profiles

58e0389

szdziedzic force-pushed the 01-16-_eas-cli_add_eas_dev_command branch from 5e655a5 to 58e0389 Compare January 30, 2025 15:25

szdziedzic added 2 commits January 30, 2025 16:29

make it hidden

6c6c364

prompt to commit after adding new build profile

b82e878

szdziedzic added the no changelog PR that doesn't require a changelog entry label Jan 30, 2025

szdziedzic merged commit 061f626 into main Jan 30, 2025
11 of 12 checks passed

szdziedzic deleted the 01-16-_eas-cli_add_eas_dev_command branch January 30, 2025 17:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENG-14625][eas-cli] add `eas build:dev` command #2820

[ENG-14625][eas-cli] add `eas build:dev` command #2820

szdziedzic commented Jan 16, 2025 •

edited

Loading

szdziedzic commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025 •

edited

Loading

brentvatne commented Jan 16, 2025 •

edited

Loading

codecov bot commented Jan 16, 2025 •

edited

Loading

szdziedzic commented Jan 16, 2025

linear bot commented Jan 16, 2025

wschurman left a comment

wschurman Jan 17, 2025

szdziedzic Jan 22, 2025

wschurman Jan 22, 2025

wschurman left a comment

wschurman Jan 22, 2025

github-actions bot commented Jan 30, 2025

[ENG-14625][eas-cli] add eas build:dev command #2820

[ENG-14625][eas-cli] add eas build:dev command #2820

Conversation

szdziedzic commented Jan 16, 2025 • edited Loading

Why

How

Test Plan

szdziedzic commented Jan 16, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 16, 2025 • edited Loading

brentvatne commented Jan 16, 2025 • edited Loading

codecov bot commented Jan 16, 2025 • edited Loading

Codecov Report

szdziedzic commented Jan 16, 2025

linear bot commented Jan 16, 2025

wschurman left a comment

Choose a reason for hiding this comment

wschurman Jan 17, 2025

Choose a reason for hiding this comment

szdziedzic Jan 22, 2025

Choose a reason for hiding this comment

wschurman Jan 22, 2025

Choose a reason for hiding this comment

wschurman left a comment

Choose a reason for hiding this comment

wschurman Jan 22, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2025

[ENG-14625][eas-cli] add `eas build:dev` command #2820

[ENG-14625][eas-cli] add `eas build:dev` command #2820

szdziedzic commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

brentvatne commented Jan 16, 2025 •

edited

Loading

codecov bot commented Jan 16, 2025 •

edited

Loading