Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] upload fingerprint from local project state #2808

Merged

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jan 8, 2025

Why

Upload the locally computed fingerprint to www when someone runs eas fingerprint:compare so they can view the diff easier from a website ui

How

  • Added new GraphQL types and mutations for fingerprint management
  • Implemented fingerprint comparison functionality in the CLI
  • Added support for uploading fingerprints to the server

Test Plan

  • manually tested eas fingerprint:compare to ensure fingerprint is uploaded

Copy link
Member Author

quinlanj commented Jan 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 8, 2025

Size Change: +1.35 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.35 kB (0%)

compressed-size-action

@quinlanj quinlanj marked this pull request as ready for review January 8, 2025 21:14
Copy link

github-actions bot commented Jan 8, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (37a32c9) to head (a94a82d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s-cli/src/graphql/mutations/FingerprintMutation.ts 62.50% 3 Missing ⚠️
...ckages/eas-cli/src/commands/fingerprint/compare.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
+ Coverage   52.48%   52.49%   +0.02%     
==========================================
  Files         583      584       +1     
  Lines       22603    22621      +18     
  Branches     4461     4461              
==========================================
+ Hits        11860    11873      +13     
- Misses      10708    10713       +5     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj force-pushed the 01-08-_eas-cli_upload_fingerprint_from_local_project_state branch from 6c96447 to a94a82d Compare January 10, 2025 16:37
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit cbfcdae into main Jan 10, 2025
11 checks passed
@quinlanj quinlanj deleted the 01-08-_eas-cli_upload_fingerprint_from_local_project_state branch January 10, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants