Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] upload local project fingerprint #2798

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jan 5, 2025

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

Copy link

github-actions bot commented Jan 5, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

quinlanj commented Jan 5, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@quinlanj quinlanj mentioned this pull request Jan 5, 2025
3 tasks
Copy link

github-actions bot commented Jan 5, 2025

Size Change: -714 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -714 B (0%)

compressed-size-action

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (a4ca87a) to head (e0083cc).

Files with missing lines Patch % Lines
...s-cli/src/graphql/mutations/FingerprintMutation.ts 62.50% 3 Missing ⚠️
...ckages/eas-cli/src/commands/fingerprint/compare.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           01-05-_eas-cli_create_debug_fingerprints    #2798      +/-   ##
============================================================================
+ Coverage                                     52.50%   52.52%   +0.02%     
============================================================================
  Files                                           583      584       +1     
  Lines                                         22583    22601      +18     
  Branches                                       4452     4452              
============================================================================
+ Hits                                          11856    11869      +13     
- Misses                                        10692    10697       +5     
  Partials                                         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj quinlanj closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant