Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move environment from metadata to job object #2777

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Move environment from metadata to job object #2777

merged 1 commit into from
Jan 30, 2025

Conversation

khamilowicz
Copy link
Contributor

@khamilowicz khamilowicz commented Dec 18, 2024 •
edited
Loading

Why

ENG-14307: move environment to job object from metadata

Environment should be considering a first class citizen in job object instead of being stored in the metadata.

How

  • Pass environment in job object
  • remove environment from metadata.

Test Plan

  1. Start a build specifying environment in eas.json.
  2. Build should use the specified environment (check on website in Build details)

@linear Linear
Copy link

linear bot commented Dec 18, 2024

ENG-14307 move environment to job object from metadata

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata branch from f5a90ba to 30dde74 Compare January 23, 2025 13:32
@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Jan 23, 2025 — with Graphite App
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Size Change: +1.79 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.79 kB (0%)

compressed-size-action

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.99%. Comparing base (01ce802) to head (b70bacb).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/utils/environment.ts 44.45% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
+ Coverage   52.62%   52.99%   +0.37%     
==========================================
  Files         584      585       +1     
  Lines       22638    22680      +42     
  Branches     4467     4723     +256     
==========================================
+ Hits        11910    12016     +106     
+ Misses      10694     9735     -959     
- Partials       34      929     +895

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khamilowicz khamilowicz marked this pull request as ready for review January 23, 2025 13:44
@github-actions GitHub Actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

sjchmiela
sjchmiela requested changes Jan 27, 2025
View reviewed changes
packages/eas-cli/src/build/utils/environment.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/build/utils/environment.ts Outdated
if (buildProfileEnvironment && isEnvironment(buildProfileEnvironment)) {
return buildProfileEnvironment;
}
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user specifies an invalid value in environment, shouldn't we throw an error and ask him to fix it instead of falling back to defaults?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eas-json already takes care of this:

image.png

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata branch from 30dde74 to 90ed39a Compare January 27, 2025 16:18
@khamilowicz khamilowicz requested a review from sjchmiela January 27, 2025 16:19
szdziedzic
szdziedzic reviewed Jan 29, 2025
View reviewed changes
packages/eas-cli/src/build/utils/environment.ts Outdated Show resolved Hide resolved
packages/eas-cli/src/build/metadata.ts
@@ -62,7 +62,6 @@ export async function collectMetadataAsync<T extends Platform>(
requiredPackageManager: ctx.requiredPackageManager ?? undefined,
selectedImage: ctx.buildProfile.image,
customNodeVersion: ctx.buildProfile.node,
environment: ctx.buildProfile.environment,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, we didn't require any mapping before. How did it work?

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata branch from 90ed39a to b70bacb Compare January 29, 2025 16:18
@github-actions GitHub Actions
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

szdziedzic
szdziedzic approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@khamilowicz khamilowicz merged commit 3159550 into main Jan 30, 2025
10 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-14307-move-environment-to-job-object-from-metadata branch January 30, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szdziedzic szdziedzic szdziedzic approved these changes

@sjchmiela sjchmiela sjchmiela approved these changes

Assignees

@szdziedzic szdziedzic

Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khamilowicz @sjchmiela @szdziedzic