-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Remove random branch name generation for --auto branch name non-vcs fallback #2747
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Size Change: +1.35 kB (0%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2747 +/- ##
==========================================
- Coverage 52.52% 52.51% -0.00%
==========================================
Files 583 583
Lines 22572 22576 +4
Branches 4445 4447 +2
==========================================
Hits 11854 11854
- Misses 10683 10687 +4
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Subscribed to pull request
Generated by CodeMention |
96ac085
to
0092ef8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
… non-vcs fallback
0092ef8
to
eaa9784
Compare
✅ Thank you for adding the changelog entry! |
Why
https://exponent-internal.slack.com/archives/C06EFBQK3B7/p1732217583248979
We should never be defaulting to a random branch name for an EAS Update. This would have disastrous consequences for usability and our interfaces, as well as for publishes and channel-branch mappings.
For workflows, this problem is more in the foreground since there's no VCS on the workflow runner.
Closes ENG-14314.
How
Remove fallback, throw an descriptive error when needed.
Test Plan
Run
neas update --auto
in a directory that doesn't have vcs (remove .git folder). See other error indicating that VCS is required.Run
neas branch:create
, see that there's no default suggestion in the prompt.