Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] revert UpdateBranchWithCurrentGroupFragment #1952

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

quinlanj
Copy link
Member

Why

In my query, I forgot I had to parameterize one of the edges so I can't make it a fragment after all. This PR switchies it over to an explicit type.

            query ViewUpdateChannelOnApp(
              $appId: String!
              $channelName: String!
              $filter: UpdatesFilter
            ) {
              app {
                byId(appId: $appId) {
                       ...
                      updateGroups(offset: 0, limit: 1, filter: $filter) { <------------ Had to parameterize this one
                      ...
            }

Test Plan

  • tests still pass

@quinlanj quinlanj requested a review from wschurman July 26, 2023 01:21
@quinlanj
Copy link
Member Author

/changelog-entry chore revert UpdateBranchWithCurrentGroupFragment

@quinlanj quinlanj marked this pull request as ready for review July 26, 2023 01:24
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Size Change: +193 B (0%)

Total Size: 42.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.1 MB +193 B (0%)

compressed-size-action

@quinlanj quinlanj changed the title [eas-ci] revert UpdateBranchWithCurrentGroupFragment [eas-cli] revert UpdateBranchWithCurrentGroupFragment Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1952 (27e0603) into main (55bce8d) will increase coverage by 0.01%.
The diff coverage is 83.34%.

@@            Coverage Diff             @@
##             main    #1952      +/-   ##
==========================================
+ Coverage   52.76%   52.76%   +0.01%     
==========================================
  Files         484      483       -1     
  Lines       17469    17470       +1     
  Branches     3495     3495              
==========================================
+ Hits         9215     9216       +1     
  Misses       8237     8237              
  Partials       17       17              
Files Changed Coverage Δ
packages/eas-cli/src/channel/utils.ts 24.64% <ø> (ø)
...ckages/eas-cli/src/graphql/queries/ChannelQuery.ts 28.00% <33.34%> (ø)
packages/eas-cli/src/channel/__tests__/fixtures.ts 100.00% <100.00%> (ø)
packages/eas-cli/src/graphql/generated.ts 100.00% <100.00%> (ø)

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also theoretically use parametrized fragments graphql/graphql-spec#204 but they're in beta (experimental): https://github.com/apollographql/graphql-tag#experimental-fragment-variables

I think I prefer not to use experimental stuff though.

@quinlanj quinlanj merged commit 7dca2c8 into main Jul 26, 2023
@quinlanj quinlanj deleted the @quin/revertFragment branch July 26, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants