[eas-cli][1/2] unify channel graphql query types #1949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
For graphql queries that have the same fields, unify them with fragments if possible. There is one exception, where plan to parameterize instead of keeping constant:
Unfortunately, graphql does not allow for parameterized fragments so I create an intersection type to unify the channel fields:
UpdateChannelObject = ViewUpdateChannelsOnAppObject & UpdateChannelByNameObject;
How
Create fragments and intersection types
Test Plan