-
Notifications
You must be signed in to change notification settings - Fork 163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for Rust. Haven't checked any other languages. Haven't searched for missing cases. We can get all those later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for elm
Related question, must we use the "examplar" name? In Elm, files must be named like their module declaration, and the module declaration does not use "Examplar" but a name appropriate for the module (same as the one in src/). So for a valid Elm file, it should be named "ModuleName.elm" and not "Examplar.elm". But in the meantime, the name of that file matters less than its content for its role. So my question is can we keep modules names or should we used "Examplar.elm"? |
Good question. I think for now we do, but we'll keep your remark in mind when implementing. CC @iHiD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for C#
Sorry for the double rename (bad english on my part) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For common-lisp
this appears fine.
Thanks for the reviews! |
A while back there was a discussion on the name of the example files. For Concept Exercises, they are not just an example, but they are the exemplar solution.
Having not yet exploded this repo, we decided to do this renaming now. I've tried to script all the changes, but the word "Example" is used rather a lot :) If there are things obviously wrong or missing, please let me know.
We will be merging this PR before the exploding, so there is relatively little time to review. Sorry about that!
In this PR I'll update the v3-docs documentation.