fix windows utf8 encoding 2/3 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsewell
requested changes
Jun 17, 2020
| } | ||
| ], | ||
| "metadata": { | ||
| "test_name": "notebook1", | ||
| "kernelspec": { | ||
| "display_name": "Python 3", | ||
| "display_name": "Python 3.7.6 64-bit ('wintest': conda)", |
There was a problem hiding this comment.
Suggested change
| "display_name": "Python 3.7.6 64-bit ('wintest': conda)", | |
| "display_name": "Python 3", |
| "language": "python", | ||
| "name": "python3" | ||
| "name": "python37664bitwintestconda98645fcb790a40ef81b350c15db9f1ca" |
There was a problem hiding this comment.
Suggested change
| "name": "python37664bitwintestconda98645fcb790a40ef81b350c15db9f1ca" | |
| "name": "python3" |
|
what's the reason for doing this in three parts? I'm a bit confused... |
|
the names were just to indicate that all three repositories need to be updated before the encoding |
chrisjsewell
approved these changes
Jun 17, 2020
|
ah gotcha OK - so we should get each PR into a state where we're ready to merge, and then do it all at once yeah? |
|
mainly just need all three before we remove item 1 in the windows instructions i.e. -- they don't individually break the PYTHONUTF8 hack |
|
sounds good - well this one looks good and we have an approval, so I'm merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second of three parts -- see jupyter-book/jupyter-book#719