Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix harvest() and more tests #8

Merged
merged 11 commits into from
May 16, 2024
Merged

Fix harvest() and more tests #8

merged 11 commits into from
May 16, 2024

Conversation

haythemsellami
Copy link
Member

@haythemsellami haythemsellami commented May 14, 2024 •
edited
Loading

  • Add internal functions to avoid re-entrancy protection.
  • e2e and unit tests.
  • Add harvestMultipleStrategies() and rebalanceMultipleStrategies().
  • Fix rebalance: load strategyData after harvesting and gulping.
  • Update harvest: revert only on negative yield, if no yield, just return.

@haythemsellami haythemsellami changed the title [WIP]Fix harvest() and more tests Fix harvest() and more tests May 16, 2024
@haythemsellami haythemsellami merged commit 4dc254a into main May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MickdeGraaf MickdeGraaf Awaiting requested review from MickdeGraaf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@haythemsellami