This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Add process_slashings
#362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NIC619
approved these changes
Mar 4, 2019
| ) | ||
| validator_index = 0 | ||
| total_penalties = 10 ** 9 # 1 ETH | ||
| penalty = penalty = _compute_individual_penalty( |
There was a problem hiding this comment.
Suggested change
| penalty = penalty = _compute_individual_penalty( | |
| penalty = _compute_individual_penalty( |
| slot=get_epoch_start_slot(current_epoch, slots_per_epoch), | ||
| ) | ||
| validator_index = 0 | ||
| total_penalties = 10 ** 9 # 1 ETH |
| ) | ||
| state = state.update_validator_balance( | ||
| validator_index=validator_index, | ||
| balance=state.validator_balances[validator_index] - penalty, |
There was a problem hiding this comment.
Should we prevent balance underflow here?
There was a problem hiding this comment.
Hmm, logically, they would be ejected before it's under the risk of underflow.
Raise a question in the spec repo: ethereum/consensus-specs#727
| ) | ||
| state = state.update_validator_registry(validator_index, validator) | ||
|
|
||
| slashing_validator_index = 0 |
There was a problem hiding this comment.
slashing_validator_index seems to be a duplicate of validator_index
hwwhww
force-pushed
the
process_slashings
branch
from
3643146 to
ae3f54a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #322
How was it fixed?
Implement as the spec.
Cute Animal Picture