Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prestate validation checks to state test loader #1134

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Feb 17, 2025

Idea originated in #961 (review)

@gumb0 gumb0 force-pushed the test/check-pre-state branch from fb524cf to a7dbe62 Compare February 17, 2025 11:56
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (d62977d) to head (adc15ef).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   94.50%   94.51%   +0.01%     
==========================================
  Files         167      167              
  Lines       18202    18240      +38     
==========================================
+ Hits        17201    17239      +38     
  Misses       1001     1001              
Flag Coverage Δ
eof_execution_spec_tests 15.34% <19.56%> (+<0.01%) ⬆️
ethereum_tests 28.29% <17.39%> (-0.03%) ⬇️
ethereum_tests_silkpre 20.82% <15.78%> (-0.01%) ⬇️
execution_spec_tests 21.09% <19.56%> (-0.01%) ⬇️
unittests 89.78% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/statetest/statetest_loader.cpp 98.01% <100.00%> (+0.07%) ⬆️
test/unittests/state_transition_create_test.cpp 100.00% <100.00%> (ø)
test/unittests/statetest_loader_test.cpp 100.00% <100.00%> (ø)

@gumb0 gumb0 self-assigned this Feb 17, 2025
@gumb0 gumb0 force-pushed the test/check-pre-state branch 7 times, most recently from d84257e to acdc602 Compare February 19, 2025 10:52
@gumb0 gumb0 marked this pull request as ready for review February 19, 2025 11:25
@gumb0 gumb0 force-pushed the test/check-pre-state branch from acdc602 to adc15ef Compare February 19, 2025 11:51
@gumb0 gumb0 requested a review from chfast February 20, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant