Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: added CRL check [WIP] #5968

Closed
wants to merge 12 commits into from
Closed

security: added CRL check [WIP] #5968

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
717f444
vendor: added cfssl/revoke, crypto/ocsp and crypto/pkcs12 packages
kayrus Jul 18, 2016
461cece
security: Implemented certificate revocation list
kayrus Jul 17, 2016
f08dfd8
CRL: Update cfssl dependency and fixed remarks
kayrus Jul 19, 2016
2b066b8
Updated deps
kayrus Jul 20, 2016
ecb04ea
Added --crl-check flag for the certs with built-in CRL info
kayrus Jul 20, 2016
b7dea95
Updated deps
kayrus Jul 20, 2016
829fb81
Added a hardfail option
kayrus Jul 20, 2016
23c6d2a
Updated cfssl/revoke
kayrus Jul 20, 2016
e016f6d
Updated PR
kayrus Jul 21, 2016
c6baf70
embed: Fixed serve() err return
kayrus Jul 21, 2016
9e0dba8
Updated cfssl/revoke
kayrus Jul 21, 2016
a8b7511
Updated cfssl/revoke pkg
kayrus Aug 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated deps
  • Loading branch information
@kayrus
kayrus committed Jul 21, 2016
commit b7dea951d3a65a9abd2e1858b09ec6b0ce2e0c13
29 changes: 14 additions & 15 deletions cmd/vendor/github.com/cloudflare/cfssl/revoke/revoke.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/tlsutil/tlsutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,10 @@ func revokeCheckHandler(req *http.Request, CRLpath string, revokeChecker *revoke
revoked, ok = revokeChecker.VerifyCertificate(cert)
}
if !ok {
return fmt.Errorf("cert check failed (CN=%s, Serial: %s)", cert.Subject.CommonName, cert.SerialNumber.String())
return fmt.Errorf("cert check failed")
}
if revoked {
return fmt.Errorf("Cert is revoked (CN=%s, Serial: %s)", cert.Subject.CommonName, cert.SerialNumber.String())
return fmt.Errorf("Cert is revoked")
}
}
return nil
Expand Down