Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include addon name directory in 'treeForAddon' (mitigate issues with Embroider when using external helpers) #394

Merged
merged 1 commit into from
Apr 28, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,16 @@ module.exports = {
destDir: '@babel/runtime/helpers/esm'
});

return this.transpileTree(babelHelpersTree, {
const transpiledHelpers = this.transpileTree(babelHelpersTree, {
'ember-cli-babel': {
// prevents the helpers from being double transpiled, and including themselves
disablePresetEnv: true
}
});

return new Funnel(transpiledHelpers, {
destDir: this.moduleName(),
});
},

treeForVendor() {
Expand Down