Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect babel "ignore" option #306

Closed
wants to merge 1 commit into from
Closed

Respect babel "ignore" option #306

wants to merge 1 commit into from

Conversation

monovertex
Copy link

In Babel 7 the ignore option is no longer valid for @babel/preset-env, so there is currently no way of providing this option through ember-cli-babel.

I followed #158, which added sourceMaps option forwarding - this PR is pretty much the same.

Food for thought: should this plugin maybe allow the user to specify options separately for babel and for the env preset, instead of forwarding these manually? Since Babel separates them, it feels a bit weird that this plugin will bundle them together, even if it abstracts the env preset usage.

Fixes #305

@monovertex
Copy link
Author

I'm not exactly sure why the Travis build fails 🤔

@houfeng0923
Copy link

ye, we need ignore. please

@houfeng0923
Copy link

@monovertex , if you use ember-auto-import , you can try skipBabel option .
i resolved my problem with it .

@monovertex
Copy link
Author

We actually needed this behavior for internal files, but we realized after opening this PR that the files were not ignored with Babel 6 either, the ignore option was, well, ignored. The original intention was to not break some sensitive code that was already ES5 and lower compliant, but they were transpiled anyway and they worked in production for quite a while.

We also realized that ignore doesn't really make sense for internal files, because then you'd have to shim the module scaffolding.

I forgot about this PR, so I will close it now, seeing that this is not really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to specify direct babel options (not preset-env options)?
2 participants