Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 8 support #148

Merged
merged 5 commits into from
May 31, 2017
Merged

Add node 8 support #148

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eb7285
[BUGFIX #147] add node 8 support
stefanpenner May 15, 2017
86260f4
skip test that is failing because babel-preset-env changed it API (wi…
stefanpenner May 31, 2017
fb07e99
skip failed test
stefanpenner May 31, 2017
5b52b66
lock to older version of preset-env (before the breaking change)
stefanpenner May 31, 2017
79a33cf
allow node 8 to fail until ember-cli is updated
stefanpenner May 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ node_js:
- "4"
- "6"
- "7"
- "8"

sudo: false

cache:
yarn: true

matrix:
fast_finish: true
allow_failures:
- env: EMBER_TRY_SCENARIO=ember-canary

sudo: false

Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ environment:
- nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "7"
- nodejs_version: "8"

cache:
- '%APPDATA%\npm-cache'
Expand Down
2 changes: 1 addition & 1 deletion node-tests/addon-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,7 @@ describe('ember-cli-babel', function() {
expect(pluginRequired).to.be.true;
});

it('returns false when targets do not require plugin', function() {
it.only('returns false when targets do not require plugin', function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanpenner sorry about that... was (foolishly) not even considering anyone else using isPluginRequired when we made string version target changes (originally targeted for 2.x) :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@existentialism not a problem. Just a surprise, glad it was easy to work around.

this.addon.project.targets = {
browsers: ['last 2 chrome versions']
};
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"co": "^4.6.0",
"common-tags": "^1.4.0",
"console-ui": "^1.0.2",
"core-object": "^3.1.0",
"ember-cli": "2.13.1",
"core-object": "^3.1.3",
"ember-cli": "2.13.2",
"ember-cli-dependency-checker": "^2.0.0",
"ember-cli-htmlbars": "^2.0.1",
"ember-cli-htmlbars-inline-precompile": "^0.4.3",
Expand All @@ -69,7 +69,7 @@
"resolve": "^1.3.3"
},
"engines": {
"node": "=> 4"
"node": ">= 4"
},
"ember-addon": {
"configPath": "tests/dummy/config"
Expand Down
Loading