Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating a helper also generates a test #1503

Merged
merged 1 commit into from
Jul 27, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* [ENHANCEMENT] Remove Blueprint lookup failure stacktrace [#1476](https://github.com/stefanpenner/ember-cli/pull/1476)
* [ENHANCEMENT] --verbose errors option to have SilentError output stacktrace [#1480](https://github.com/stefanpenner/ember-cli/pull/1480)
* [BUGFIX] Modify service blueprint to create explicit injection [#1493](https://github.com/stefanpenner/ember-cli/pull/1493)
* [ENHANCEMENT] Generating a helper now also generates a test [#1503](https://github.com/stefanpenner/ember-cli/pull/1503)

### 0.0.40

Expand Down
8 changes: 6 additions & 2 deletions blueprints/helper/files/app/helpers/__name__.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import Ember from 'ember';

export default Ember.Handlebars.makeBoundHelper(function(value) {
function <%= camelizedModuleName %>(value) {
return value;
});
}

export { <%= camelizedModuleName %> };

export default Ember.Handlebars.makeBoundHelper(<%= camelizedModuleName %>);
9 changes: 9 additions & 0 deletions blueprints/helper/files/tests/unit/helpers/__name__-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { <%= camelizedModuleName %> } from '<%= dasherizedPackageName %>/helpers/<%= dasherizedModuleName %>';

module('<%= classifiedModuleName %>Helper');

// Replace this with your real tests.
test('it works', function() {
var result = <%= camelizedModuleName %>(42);
ok(result);
});
18 changes: 14 additions & 4 deletions tests/acceptance/generate-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,14 @@ describe('Acceptance: ember generate', function() {
return generate(['helper', 'foo-bar']).then(function() {
assertFile('app/helpers/foo-bar.js', {
contains: "import Ember from 'ember';\n\n" +
"export default Ember.Handlebars.makeBoundHelper(function(value) {\n" +
"function fooBar(value) {\n" +
" return value;\n" +
"});"
"}\n\n" +
"export { fooBar };\n\n" +
"export default Ember.Handlebars.makeBoundHelper(fooBar);"
});
assertFile('tests/unit/helpers/foo-bar-test.js', {
contains: "import { fooBar } from 'my-app/helpers/foo-bar';"
});
});
});
Expand All @@ -139,9 +144,14 @@ describe('Acceptance: ember generate', function() {
return generate(['helper', 'foo/bar-baz']).then(function() {
assertFile('app/helpers/foo/bar-baz.js', {
contains: "import Ember from 'ember';\n\n" +
"export default Ember.Handlebars.makeBoundHelper(function(value) {\n" +
"function fooBarBaz(value) {\n" +
" return value;\n" +
"});"
"}\n\n" +
"export { fooBarBaz };\n\n" +
"export default Ember.Handlebars.makeBoundHelper(fooBarBaz);"
});
assertFile('tests/unit/helpers/foo/bar-baz-test.js', {
contains: "import { fooBarBaz } from 'my-app/helpers/foo/bar-baz';"
});
});
});
Expand Down