Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting from #107, avoid referencing the
Ember
global.This PR only updates the "main" JS implementation. It does not attempt to remove global
Ember
interactions from the template compilation deprecation catcher. #107 simply removed the template compilation catcher, which I would like to avoid doing.This PR would require that users of deprecation workflow add
setup(self)
to theirapp.js
or another appropriate location. Likely they might want to only callsetup(
if running in a dev build. It isn't clear exactly how to document/automate that. (Finally it is possible someone might want to run deprecation workflow in a production build when running tests. That should be left as an exercise to the consumer IMO). We can probably suggest using https://api.emberjs.com/ember/3.26/classes/@ember%2Fdebug/methods/runInDebug?anchor=runInDebugIt also isn't clear if the payload in
addon/index.js
will still be a no-op in production. Generally deprecation workflow today is pretty clever about not adding any weight (from the config file or from its JS) to production builds. We likely need a solution for this since the config file is obnoxious to ship to prod, but this PR doesn't address/change the config file anyway.TODO:
setup(
being added upon installation, or document it