Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: formatting #643

Merged
merged 87 commits into from
Feb 16, 2024
Merged

chore: formatting #643

merged 87 commits into from
Feb 16, 2024

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 16, 2024 •
edited
Loading

Ready for review Powered by Pull Request Badge

Summary

This is a stop-the-world PR which updates all files in the codebase. While we're here, the goal is to run all tools which would touch everything at once, get it merged (+fixes), and then rebase aggressively.

On this branch, check passes, and spotlessApply yields no changes. These conditions aren't yet enforced, and there is a significant baseline backlog of issues, but we can effectively start the process of clamping from here.

This should be squash-merged, definitely, to prevent merge conflicts when rebasing across these commits. Because of this PR's size, review is probably best conducted from inside the IDE. Test command:

./gradlew allTests test check --no-configuration-cache

Tasklist

  • Run import optimizer
  • Support for ktlint
  • Support for Diktat
  • Enhanced support for Detekt
  • Enhanced support for Prettier
  • Support for Google Java Format
  • Support for OWASP checks
  • Completely eliminate all usages of subprojects and allprojects
  • Move all linting into conventions, added conventions for Dokka
  • Update all license headers to 2024, and set company to Elide Technologies, Inc.
  • Update API docs
  • Upgrade Micronaut Platform → 4.3.2

Action taken based on enclosed changes

  • Eliminate many CVEs by upgrading, pinning, and eliminating dependencies
  • Run all formatters, apply all auto-fixes
  • Apply pending version changes from Dependabot
  • Update Kotlin wrappers and apply newest Kotlin JS symbol changes

Included PRs

cc / @darvld @coderabbitai ignore

@sgammon sgammon added dependencies Pull requests that update a dependency file java Pull requests that update Java code github_actions Pull requests that update GitHub Actions code ✋ embargoed PRs and issues that can't proceed because of some non-code condition module:graalvm Modules, changes, and issues relating to GraalVM module:frontend Modules, changes, and issues relating to Elide for browsers module:server Modules, changes, and issues relating to Elide for servers module:base Changes and issues relating to the Elide `base` module module:rpc Modules, changes, and issues relating to the Elide RPC layer module:model Modules, changes, and issues relating to the Elide model layer platform:jvm PRs and issues relating to JVM support. 🚧 WIP Works-in-progress. Blocks merge platform:browser PRs and issues relating to browser support. dev Dev tools, CI/CD, and other devops topics module:core Changes and issues relating to the Elide `core` module module:cli CLI module issues and features P0 labels Feb 16, 2024
@sgammon sgammon added this to the Release R4: Alpha 8 milestone Feb 16, 2024
@sgammon sgammon self-assigned this Feb 16, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 16, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@commitlint/[email protected] Transitive: environment, filesystem, shell, unsafe +156 43.2 MB escapedcat
npm/@commitlint/[email protected] Transitive: filesystem +12 179 kB escapedcat
npm/@prettier/[email protected] Transitive: environment, eval, filesystem, unsafe +4 10.8 MB kddeisz
npm/@types/[email protected] None +1 4.07 MB types
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +128 48.9 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +123 45.9 MB jameshenry
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +157 43.2 MB escapedcat
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +97 10.7 MB eslintbot
npm/[email protected] environment, filesystem, network, unsafe Transitive: eval, shell +74 19.3 MB evilebottnawi

🚮 Removed packages: npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@sgammon sgammon requested review from darvld and a team and removed request for darvld February 16, 2024 04:03
@sgammon
chore: run formatters, update license header
921f470 
- chore: update license header to new company name
- chore: update license header year specification

Signed-off-by: Sam Gammon <[email protected]>
@sgammon
chore: ability to disable spotless on per-module basis
d06c6ee 
Signed-off-by: Sam Gammon <[email protected]>
@sgammon
chore: disable spotless where ktlint crashes
3f2a6af 
Signed-off-by: Sam Gammon <[email protected]>
@sgammon
chore: ktlint tuning before run
1050db0 
Signed-off-by: Sam Gammon <[email protected]>
@sgammon
chore: run import optimizer
e00a0a0 
Signed-off-by: Sam Gammon <[email protected]>
@sgammon
feat: conventions for ktlint, diktat support
098b012 
Signed-off-by: Sam Gammon <[email protected]>
@sgammon
chore: further ktlint tuning
9444519 
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon removed the ✋ embargoed PRs and issues that can't proceed because of some non-code condition label Feb 16, 2024
@sgammon sgammon removed the request for review from a team February 16, 2024 05:48
@sgammon sgammon marked this pull request as ready for review February 16, 2024 05:48
@sgammon sgammon force-pushed the chore/formatting branch 2 times, most recently from c1bf00b to 2db46cf Compare February 16, 2024 05:50
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sgammon sgammon merged commit f335d88 into main Feb 16, 2024
@sgammon sgammon deleted the chore/formatting branch February 16, 2024 07:12
@sgammon sgammon mentioned this pull request Apr 18, 2024
Merged
13 tasks
@sgammon sgammon removed the 🚧 WIP Works-in-progress. Blocks merge label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgammon sgammon

Labels
dependencies Pull requests that update a dependency file dev Dev tools, CI/CD, and other devops topics github_actions Pull requests that update GitHub Actions code java Pull requests that update Java code module:base Changes and issues relating to the Elide `base` module module:cli CLI module issues and features module:core Changes and issues relating to the Elide `core` module module:frontend Modules, changes, and issues relating to Elide for browsers module:graalvm Modules, changes, and issues relating to GraalVM module:model Modules, changes, and issues relating to the Elide model layer module:rpc Modules, changes, and issues relating to the Elide RPC layer module:server Modules, changes, and issues relating to Elide for servers P0 platform:browser PRs and issues relating to browser support. platform:jvm PRs and issues relating to JVM support.
Projects
Elide
Status: Done
Milestone
Release R4: Alpha 8
Development

Successfully merging this pull request may close these issues.
1 participant
@sgammon