Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor composer UI components to separate files #1506

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

jonnyandrew
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

  • Extract UI components from TextComposer.kt into separate files.
  • No code changes except new previews.

Motivation and context

Screenshots / GIFs

N/A

Tests

N/A

Tested devices

  • Physical
  • Emulator
  • OS version(s): N/A

Checklist

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oFXzcj

@jonnyandrew jonnyandrew marked this pull request as ready for review October 6, 2023 10:37
@jonnyandrew jonnyandrew requested a review from a team as a code owner October 6, 2023 10:37
@jonnyandrew jonnyandrew requested review from ganfra and removed request for a team October 6, 2023 10:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (daf46d7) 58.70% compared to head (b58b359) 58.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1506      +/-   ##
===========================================
- Coverage    58.70%   58.69%   -0.02%     
===========================================
  Files         1133     1137       +4     
  Lines        30300    30308       +8     
  Branches      6215     6223       +8     
===========================================
  Hits         17789    17789              
- Misses        9840     9843       +3     
- Partials      2671     2676       +5     
Files Coverage Δ
...ent/android/libraries/textcomposer/TextComposer.kt 81.45% <ø> (+7.04%) ⬆️
...s/textcomposer/components/ComposerOptionsButton.kt 33.33% <33.33%> (ø)
...composer/components/DismissTextFormattingButton.kt 33.33% <33.33%> (ø)
...id/libraries/textcomposer/components/SendButton.kt 81.08% <81.08%> (ø)
...ibraries/textcomposer/components/TextFormatting.kt 54.80% <54.80%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jonnyandrew jonnyandrew merged commit 6e9d198 into develop Oct 10, 2023
@jonnyandrew jonnyandrew deleted the jonny/extract-composer-components branch October 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants