Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress a flaky internal mypy error appearing randomly when executing make lint. #1919

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

fressi-elastic
Copy link
Contributor

@fressi-elastic fressi-elastic commented Mar 3, 2025

Fixes Rally issue #1918.

@gbanasiak
Copy link
Contributor

@fressi-elastic I've removed \@sakurai-youhei, no need to engage him. Better to use @elastic/es-perf unless someone has specific context. The scope of the change is bigger than the title, is that expected?

@fressi-elastic
Copy link
Contributor Author

fressi-elastic commented Mar 3, 2025

@fressi-elastic I've removed \@sakurai-youhei, no need to engage him. Better to use @elastic/es-perf unless someone has specific context. The scope of the change is bigger than the title, is that expected?

No the scope is the one in the title. I included other changes by mistake. I am sorry for it. I am going to remove unrelated changes from this one.

@fressi-elastic fressi-elastic changed the title Workaround a flaky internal mypy error appearing randomly when executing make lint. Suppress a flaky internal mypy error appearing randomly when executing make lint. Mar 3, 2025
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this makes mypy check slower under pre-commit, but correctness is more important than speed. We can revisit if this becomes too slow for us for some reason.

@fressi-elastic
Copy link
Contributor Author

The speed difference are irrelevants with my M4 14 cores MacBook. I also guess that the reason I see so many errors is because I was working with so many fast cores. With less and slower cores probably race conditions are harder to spot. Anyway considering the correctness and reliability of tests is much more important than speed I agree that we should wait the bug is fixed on mypy side before restoring this configuration as it was before.

@fressi-elastic fressi-elastic merged commit d1859d5 into elastic:master Mar 3, 2025
15 checks passed
@fressi-elastic fressi-elastic deleted the issue/1918 branch March 4, 2025 11:01
@dpifke-elastic dpifke-elastic added the bug Something's wrong label Mar 28, 2025
@dpifke-elastic dpifke-elastic added this to the 2.12.0 milestone Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants