-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress a flaky internal mypy error appearing randomly when executing make lint
.
#1919
Conversation
90e6e0a
to
a03d8b4
Compare
95433b0
to
b110850
Compare
@fressi-elastic I've removed |
No the scope is the one in the title. I included other changes by mistake. I am sorry for it. I am going to remove unrelated changes from this one. |
b110850
to
0cac391
Compare
make lint
.make lint
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this makes mypy
check slower under pre-commit
, but correctness is more important than speed. We can revisit if this becomes too slow for us for some reason.
The speed difference are irrelevants with my M4 14 cores MacBook. I also guess that the reason I see so many errors is because I was working with so many fast cores. With less and slower cores probably race conditions are harder to spot. Anyway considering the correctness and reliability of tests is much more important than speed I agree that we should wait the bug is fixed on |
Fixes Rally issue #1918.