Add ability to provide a list as input for disk-usage-stats #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbanasiak
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Sorry, haven't seen this earlier.
There's another comma-separated string in telemetry: node-stats-include-indices-metrics in node-stats. It has a different behavior, exception is thrown when parameter is not a string. This happens on start, so that's less frustrating for a user. WDYT about aligning both to either support both formats (string and list) or throw a similar exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently expect a comma separated list of indices, however its possible to provide a list, which then ends up crashing rally at the end of a race. Since the parameter is in plural, it makes sense to at least support providing a list. This checks that if the parameter is a list, and if so convert to comma separated