Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecate use of resources.read_text() function. #1911

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

fressi-elastic
Copy link
Contributor

This fixes the issue by replacing the deprecated function with the code suggested by Python documentation.

Copy link
Contributor

@favilo favilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fressi-elastic
Copy link
Contributor Author

I just added the unit test.

@fressi-elastic fressi-elastic merged commit d0aa512 into elastic:master Feb 5, 2025
15 checks passed
@fressi-elastic fressi-elastic deleted the issue/1910 branch February 5, 2025 13:45
fressi-elastic added a commit to fressi-elastic/rally that referenced this pull request Mar 3, 2025
@dpifke-elastic dpifke-elastic added the cleanup Linter changes, reformatting, removal of unused code etc. label Mar 28, 2025
@dpifke-elastic dpifke-elastic added this to the 2.12.0 milestone Mar 28, 2025
@dpifke-elastic dpifke-elastic added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants